Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to linking UI #1998

Merged
merged 21 commits into from
May 13, 2019
Merged

Improvements to linking UI #1998

merged 21 commits into from
May 13, 2019

Conversation

astrofrog
Copy link
Member

This includes a few improvements to the linking user interface based on user feedback :)

The UI still 'jumps around' a little when selecting different things, so it will require a little more work.

@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #1998 into master will increase coverage by 0.01%.
The diff coverage is 96.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1998      +/-   ##
==========================================
+ Coverage   87.76%   87.77%   +0.01%     
==========================================
  Files         248      247       -1     
  Lines       21712    21673      -39     
==========================================
- Hits        19055    19023      -32     
+ Misses       2657     2650       -7
Impacted Files Coverage Δ
glue/plugins/dendro_viewer/layer_style_editor.py 0% <0%> (ø) ⬆️
glue/viewers/scatter/qt/layer_style_editor.py 92.7% <100%> (ø) ⬆️
...lue/plugins/dendro_viewer/qt/layer_style_editor.py 100% <100%> (ø) ⬆️
glue/app/qt/save_data.py 100% <100%> (ø) ⬆️
glue/plugins/dendro_viewer/qt/options_widget.py 92.85% <100%> (ø) ⬆️
glue/viewers/histogram/qt/options_widget.py 86.66% <100%> (ø) ⬆️
glue/viewers/image/qt/layer_style_editor.py 100% <100%> (ø) ⬆️
glue/viewers/histogram/qt/layer_style_editor.py 100% <100%> (ø) ⬆️
glue/viewers/profile/qt/layer_style_editor.py 100% <100%> (ø) ⬆️
glue/dialogs/link_editor/qt/link_editor.py 98.68% <100%> (+0.27%) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48181a7...fccd2e8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant