Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collapse tool when dragging from right to left #2002

Merged
merged 2 commits into from
May 13, 2019

Conversation

astrofrog
Copy link
Member

@astrofrog astrofrog commented May 10, 2019

Still needs tests and need to make fixed_resolution_buffer function more robust to this kind of issue

@astrofrog astrofrog added the bug label May 10, 2019
@astrofrog astrofrog added this to the v0.14.3 milestone May 10, 2019
@astrofrog astrofrog marked this pull request as ready for review May 13, 2019 10:52
@codecov
Copy link

codecov bot commented May 13, 2019

Codecov Report

Merging #2002 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2002      +/-   ##
==========================================
- Coverage   87.76%   87.69%   -0.07%     
==========================================
  Files         248      248              
  Lines       21712    21713       +1     
==========================================
- Hits        19055    19042      -13     
- Misses       2657     2671      +14
Impacted Files Coverage Δ
glue/viewers/image/state.py 90.09% <ø> (ø) ⬆️
glue/viewers/profile/qt/profile_tools.py 90.08% <100%> (+0.04%) ⬆️
glue/version.py 71.42% <0%> (-28.58%) ⬇️
glue/utils/qt/app.py 86.95% <0%> (-8.7%) ⬇️
glue/__init__.py 69.56% <0%> (-4.35%) ⬇️
glue/conftest.py 66% <0%> (-4%) ⬇️
glue/app/qt/preferences.py 92.3% <0%> (-2.57%) ⬇️
glue/viewers/matplotlib/qt/widget.py 77.52% <0%> (-1.13%) ⬇️
glue/core/data_factories/fits.py 87.59% <0%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48181a7...2d982ff. Read the comment docs.

@astrofrog astrofrog merged commit f4b7110 into glue-viz:master May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant