Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with categorical histograms #2009

Merged
merged 2 commits into from
May 15, 2019

Conversation

astrofrog
Copy link
Member

Fixed bug that caused labels on the x-axis of the histogram viewer to be incorrectly set to numbers instead of strings when showing a histogram of a string variable and saving/reloading session

… be incorrectly set to numbers instead of strings when showing a histogram of a string variable and saving/reloading session
@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #2009 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2009      +/-   ##
==========================================
+ Coverage   88.03%   88.03%   +<.01%     
==========================================
  Files         244      244              
  Lines       21408    21409       +1     
==========================================
+ Hits        18847    18848       +1     
  Misses       2561     2561
Impacted Files Coverage Δ
glue/viewers/histogram/viewer.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaeeb39...7aed1ff. Read the comment docs.

@astrofrog astrofrog merged commit 6eecf7c into glue-viz:master May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant