Fix bug in autoconnect_callbacks_to_qt #2032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wo widgets connected to the same state property, we need to use the widget name (since that is guaranteed to be unique) as the key to the dictionary of handlers. Prior to this, some connections would have no references and get disconnected.
astrofrog
added a commit
that referenced
this pull request
Jun 24, 2019
Fix bug in autoconnect_callbacks_to_qt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug caused the x/y/z_stretch sliders in the 3D viewers to not work correctly because they were linked to the same state callback property as the text box with the slider value.