-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up CI with Azure Pipelines #2060
Conversation
f3acbc1
to
b406d38
Compare
ea0d421
to
3951cb0
Compare
3951cb0
to
33a0721
Compare
Codecov Report
@@ Coverage Diff @@
## master #2060 +/- ##
==========================================
- Coverage 88.13% 87.71% -0.42%
==========================================
Files 245 245
Lines 21493 21493
==========================================
- Hits 18942 18853 -89
- Misses 2551 2640 +89
Continue to review full report at Codecov.
|
36160c4
to
667468e
Compare
…tsByName. The error happens following the change in python/cpython#13589. Basically it looks like connectSlotsByName causes all properties of the Qt class to be accessed, but the viewer property didn't previously work before the load_ui call since _viewer wasn't defined and an AttributeError was raised. The fix here is to make sure that self._viewer is defined before load_ui is called.
…dded legacy configuration. Also updated minimum version of Numpy to 1.11 and QtPy to 1.3.
f0c2de3
to
94da970
Compare
94da970
to
65a97eb
Compare
d2c56f5
to
701d56b
Compare
94ce7f1
to
b692c32
Compare
…5 or PySide2 - instead keep testing it on Travis until we remove support for it.
b692c32
to
74da110
Compare
I'll punt on adding back |
The numpy/astropy dev build should be fixed once astropy/astropy#9098 is merged, and the AppVeyor failure is just due to the lack of appveyor config in the repo (this won't appear in future PRs) |
Still needs to be done:
--no-optional-skip