Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up CI with Azure Pipelines #2060

Merged
merged 16 commits into from
Aug 13, 2019
Merged

Set up CI with Azure Pipelines #2060

merged 16 commits into from
Aug 13, 2019

Conversation

astrofrog
Copy link
Member

@astrofrog astrofrog commented Aug 12, 2019

Still needs to be done:

  • Set up coverage reporting
  • Determine what needs to be kept for CircleCI
  • Determine what needs to be kept for Travis CI
  • Determine what needs to be kept for AppVeyor
  • Set up docs build
  • Consider adding a configuration with old/legacy dependencies
  • Build without Qt and without qt/ directories
  • Decide whether to re-instate --no-optional-skip

@astrofrog astrofrog force-pushed the azure-pipelines-ci branch 2 times, most recently from ea0d421 to 3951cb0 Compare August 12, 2019 19:28
@codecov
Copy link

codecov bot commented Aug 13, 2019

Codecov Report

Merging #2060 into master will decrease coverage by 0.41%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2060      +/-   ##
==========================================
- Coverage   88.13%   87.71%   -0.42%     
==========================================
  Files         245      245              
  Lines       21493    21493              
==========================================
- Hits        18942    18853      -89     
- Misses       2551     2640      +89
Impacted Files Coverage Δ
glue/_deps.py 56.71% <ø> (-17.17%) ⬇️
glue/viewers/profile/qt/profile_tools.py 90.08% <100%> (ø) ⬆️
glue/conftest.py 51.92% <0%> (-19.24%) ⬇️
glue/plugins/wcs_autolinking/__init__.py 85.71% <0%> (-14.29%) ⬇️
glue/_mpl_backend.py 86.36% <0%> (-13.64%) ⬇️
glue/utils/wcs.py 86.27% <0%> (-12.75%) ⬇️
glue/utils/decorators.py 58.33% <0%> (-8.34%) ⬇️
glue/utils/noconflict.py 86.04% <0%> (-6.98%) ⬇️
glue/viewers/histogram/python_export.py 90.24% <0%> (-2.44%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7e3c93...94ce7f1. Read the comment docs.

…tsByName. The error happens following the change in python/cpython#13589. Basically it looks like connectSlotsByName causes all properties of the Qt class to be accessed, but the viewer property didn't previously work before the load_ui call since _viewer wasn't defined and an AttributeError was raised. The fix here is to make sure that self._viewer is defined before load_ui is called.
…dded legacy configuration. Also updated minimum version of Numpy to 1.11 and QtPy to 1.3.
@astrofrog astrofrog force-pushed the azure-pipelines-ci branch 2 times, most recently from 94ce7f1 to b692c32 Compare August 13, 2019 13:46
…5 or PySide2 - instead keep testing it on Travis until we remove support for it.
@astrofrog
Copy link
Member Author

I'll punt on adding back --no-optional-skip to a separate PR, as I think it would be good to go ahead and merge this one to solve the CI issues.

@astrofrog
Copy link
Member Author

The numpy/astropy dev build should be fixed once astropy/astropy#9098 is merged, and the AppVeyor failure is just due to the lack of appveyor config in the repo (this won't appear in future PRs)

@astrofrog astrofrog merged commit 9b8222f into master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant