Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bugs related to profile viewer and loading session files #2078

Merged
merged 9 commits into from
Jan 16, 2020

Conversation

astrofrog
Copy link
Member

This fixes several bugs:

  • Fixed a bug with the profile viewer which caused layers to not update correctly when changing the reference data
  • Fixed issue with reloading session with profile viewer that has a non-default reference data
  • Improve how we deal with backward-compatibility related to change in Data.coords to None

@astrofrog astrofrog added this to the v0.16.0 milestone Jan 15, 2020
@codecov
Copy link

codecov bot commented Jan 15, 2020

Codecov Report

Merging #2078 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2078      +/-   ##
==========================================
+ Coverage   90.22%   90.28%   +0.05%     
==========================================
  Files         397      397              
  Lines       39165    39245      +80     
==========================================
+ Hits        35338    35432      +94     
+ Misses       3827     3813      -14
Impacted Files Coverage Δ
glue/viewers/profile/layer_artist.py 95.78% <ø> (ø) ⬆️
glue/core/tests/test_application_base.py 94.73% <ø> (-0.06%) ⬇️
glue/core/data_factories/helpers.py 91.93% <100%> (+0.22%) ⬆️
glue/viewers/profile/state.py 98.82% <100%> (+0.08%) ⬆️
glue/core/state.py 91.7% <100%> (+0.14%) ⬆️
glue/tests/test_session_back_compat.py 100% <100%> (ø) ⬆️
glue/viewers/profile/qt/tests/test_data_viewer.py 99.46% <100%> (+0.06%) ⬆️
glue/plugins/dendro_viewer/data_factory.py 100% <0%> (+2.27%) ⬆️
glue/app/qt/preferences.py 91.05% <0%> (+2.43%) ⬆️
glue/viewers/matplotlib/qt/widget.py 81.81% <0%> (+4.54%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0636a1c...79a1f0f. Read the comment docs.

@astrofrog astrofrog merged commit 0cb0eba into glue-viz:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant