-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor coordinates API to use APE 14 #2079
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2079 +/- ##
==========================================
- Coverage 90.27% 87.95% -2.32%
==========================================
Files 394 243 -151
Lines 39190 22090 -17100
==========================================
- Hits 35377 19430 -15947
+ Misses 3813 2660 -1153
Continue to review full report at Codecov.
|
This was referenced Jan 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the Coordinates infrastructure to now operate on coordinate objects compliant with the universal APE 14 WCS API developed by the Astropy project (but not specific to astronomy). This will make it easier to make use of e.g. GWCS, and also means that we no longer need to rely on the hack of trying to translate various coordinate classes to WCS objects for the purposes of display in WCSAxes (which can work with any APE 14-compatible coordinates). We can also then leverage any utilities developed for this API for free without having to write our own versions.
This is not yet finished - in particular, I need to:
pixel2world
andworld2pixel
methods from the various classesAffineCoordinates
to no longer use the WCS classFixes #2061