Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed IndexedData to properly handle world coordinates #2081

Merged
merged 5 commits into from
Jan 31, 2020

Conversation

astrofrog
Copy link
Member

@Cadair - this will allow world coordinates to be shown when using the pixel selection tool in glue-solar!

Fixes #1961

@codecov
Copy link

codecov bot commented Jan 30, 2020

Codecov Report

Merging #2081 into master will increase coverage by <.01%.
The diff coverage is 88.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2081      +/-   ##
==========================================
+ Coverage   87.98%   87.98%   +<.01%     
==========================================
  Files         245      245              
  Lines       22101    22131      +30     
==========================================
+ Hits        19445    19472      +27     
- Misses       2656     2659       +3
Impacted Files Coverage Δ
glue/core/coordinates.py 90.62% <100%> (-0.42%) ⬇️
glue/core/data_factories/pandas.py 85% <100%> (ø) ⬆️
glue/core/data_derived.py 97.58% <100%> (+1.18%) ⬆️
glue/core/data.py 92.05% <79.16%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4c7dfe...7a26c23. Read the comment docs.

@astrofrog astrofrog merged commit 1d9ae85 into glue-viz:master Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deal properly with world coordinates when using IndexedData
1 participant