Fix issue where profile of subset was not correctly hidden if the subset was emptied #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2095 +/- ##
==========================================
- Coverage 87.99% 87.99% -0.01%
==========================================
Files 245 245
Lines 22131 22130 -1
==========================================
- Hits 19475 19474 -1
Misses 2656 2656
Continue to review full report at Codecov.
|
…set was changed to be empty. This is because we were simply hiding the profile in this case but it got shown again when setting the visual properties.
astrofrog
force-pushed
the
fix-empty-profile
branch
from
6d7e8b6 to
197015e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was first spotted in glue-jupyter (glue-viz/glue-jupyter#160) but the issue exists in glue-core too.