Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2003: Have a way of seeing what session file was opened #2096

Merged
merged 4 commits into from
Apr 2, 2020

Conversation

specmicp
Copy link
Contributor

@specmicp specmicp commented Mar 8, 2020

This commit add the session filename in the window title

The window title is updated on export, restore and reset.

@codecov
Copy link

codecov bot commented Mar 8, 2020

Codecov Report

Merging #2096 into master will decrease coverage by 0.01%.
The diff coverage is 93.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2096      +/-   ##
==========================================
- Coverage   87.98%   87.97%   -0.02%     
==========================================
  Files         245      244       -1     
  Lines       22132    22279     +147     
==========================================
+ Hits        19473    19600     +127     
- Misses       2659     2679      +20     
Impacted Files Coverage Δ
glue/viewers/image/state.py 91.31% <ø> (ø)
glue/viewers/profile/state.py 98.83% <ø> (+0.01%) ⬆️
glue/viewers/image/layer_artist.py 89.62% <60.00%> (+0.14%) ⬆️
glue/core/data_combo_helper.py 91.53% <77.77%> (-0.45%) ⬇️
glue/app/qt/application.py 78.63% <90.90%> (+0.13%) ⬆️
glue/core/data_factories/pandas.py 85.00% <100.00%> (ø)
glue/core/qt/layer_artist_model.py 83.69% <100.00%> (ø)
glue/viewers/common/viewer.py 90.59% <100.00%> (ø)
glue/viewers/scatter/layer_artist.py 97.83% <100.00%> (-0.29%) ⬇️
glue/viewers/scatter/qt/layer_style_editor.py 93.86% <100.00%> (+0.76%) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39eaaf0...026f50f. Read the comment docs.

Add the session filename in the window title

Update on export, restore and reset
Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! I just pushed a small tweak to make sure it works fine when loading session files from the command-line.

@astrofrog astrofrog merged commit 5078e16 into glue-viz:master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants