Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug that caused issues when saving and re-loading sessions with Excel data #2101

Merged
merged 2 commits into from
Mar 12, 2020

Conversation

astrofrog
Copy link
Member

String columns from Excel files were incorrectly read in as object arrays.

…at were originally created using Excel data with string columns. These columns were incorrectly read in as object arrays.
@astrofrog astrofrog added this to the v0.15.7 milestone Mar 12, 2020
@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #2101 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2101      +/-   ##
==========================================
- Coverage   87.99%   87.99%   -0.01%     
==========================================
  Files         245      245              
  Lines       22131    22134       +3     
==========================================
+ Hits        19475    19476       +1     
- Misses       2656     2658       +2
Impacted Files Coverage Δ
glue/core/data_factories/pandas.py 85% <100%> (ø) ⬆️
glue/viewers/matplotlib/qt/widget.py 78.4% <0%> (-3.41%) ⬇️
glue/viewers/table/qt/data_viewer.py 96.77% <0%> (+0.04%) ⬆️
glue/__init__.py 70.37% <0%> (+3.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e27946...806ea07. Read the comment docs.

@astrofrog astrofrog merged commit 0d28456 into glue-viz:master Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant