Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug that caused an error when an invalid data was added to the table viewer #2103

Merged
merged 1 commit into from
Mar 12, 2020

Conversation

astrofrog
Copy link
Member

and the table viewer was then automatically closed. The error was:

AttributeError: 'NoneType' object has no attribute '_data'

…e table viewer and the table viewer was then automatically closed.
@codecov
Copy link

codecov bot commented Mar 12, 2020

Codecov Report

Merging #2103 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2103      +/-   ##
==========================================
+ Coverage   87.99%   88.03%   +0.04%     
==========================================
  Files         245      245              
  Lines       22131    22132       +1     
==========================================
+ Hits        19475    19485      +10     
+ Misses       2656     2647       -9
Impacted Files Coverage Δ
glue/viewers/table/qt/data_viewer.py 96.74% <100%> (+0.01%) ⬆️
glue/plugins/dendro_viewer/data_factory.py 97.72% <0%> (-2.28%) ⬇️
glue/app/qt/application.py 79.57% <0%> (+1.06%) ⬆️
glue/__init__.py 70.37% <0%> (+3.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e27946...3c11e12. Read the comment docs.

@astrofrog astrofrog merged commit 83e163a into glue-viz:master Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant