Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance improvements #2115

Merged
merged 4 commits into from
Apr 2, 2020
Merged

Performance improvements #2115

merged 4 commits into from
Apr 2, 2020

Conversation

astrofrog
Copy link
Member

@astrofrog astrofrog commented Apr 1, 2020

  • Improve performance of volume rendering with cubes that had uncorrelated axes when relying on reprojection (especially involving celestial coordinate transformations)

  • Improve performance of profile viewer for subsets defined using only some pixel axes

  • Improve performance of profile viewer by not computing profiles for non-visible layers.

…when using linked datasets with some axes uncorrelated
@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #2115 into master will decrease coverage by 0.02%.
The diff coverage is 73.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2115      +/-   ##
==========================================
- Coverage   88.01%   87.98%   -0.03%     
==========================================
  Files         244      244              
  Lines       22249    22270      +21     
==========================================
+ Hits        19582    19595      +13     
- Misses       2667     2675       +8     
Impacted Files Coverage Δ
glue/core/data.py 91.11% <57.89%> (-0.95%) ⬇️
glue/core/fixed_resolution_buffer.py 94.64% <87.50%> (-0.65%) ⬇️
glue/utils/array.py 95.34% <100.00%> (+0.03%) ⬆️
glue/viewers/profile/layer_artist.py 95.78% <100.00%> (+1.05%) ⬆️
glue/viewers/profile/state.py 98.83% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 760ae0a...f6dab34. Read the comment docs.

@astrofrog astrofrog merged commit 5839048 into glue-viz:master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant