Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed missing .units on CoordinateComponent #2117

Merged
merged 1 commit into from
Apr 6, 2020

Conversation

astrofrog
Copy link
Member

This was an oversight, we should pull in the units from the WCS

@astrofrog astrofrog added the bug label Apr 6, 2020
@astrofrog astrofrog added this to the v0.16.0 milestone Apr 6, 2020
@codecov
Copy link

codecov bot commented Apr 6, 2020

Codecov Report

Merging #2117 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2117      +/-   ##
==========================================
+ Coverage   87.99%   88.05%   +0.06%     
==========================================
  Files         245      245              
  Lines       22318    22322       +4     
==========================================
+ Hits        19638    19655      +17     
+ Misses       2680     2667      -13     
Impacted Files Coverage Δ
glue/core/component.py 97.05% <100.00%> (+0.05%) ⬆️
glue/app/qt/application.py 79.69% <0.00%> (+1.05%) ⬆️
glue/viewers/matplotlib/qt/widget.py 81.81% <0.00%> (+3.40%) ⬆️
glue/__init__.py 70.37% <0.00%> (+3.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3103bf...1b668f6. Read the comment docs.

@astrofrog astrofrog merged commit e8294ea into glue-viz:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant