Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the bundled 'echo' package #2125

Merged
merged 8 commits into from
Apr 18, 2020
Merged

Conversation

astrofrog
Copy link
Member

This removes the bundled version of echo in favor of the standalone package. For now, this requires the developer version of echo since I don't yet have permission to upload new releases to PyPI.

@astrofrog astrofrog added this to the v0.16.0 milestone Apr 13, 2020
@codecov
Copy link

codecov bot commented Apr 13, 2020

Codecov Report

Merging #2125 into master will increase coverage by 0.01%.
The diff coverage is 96.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2125      +/-   ##
==========================================
+ Coverage   87.99%   88.00%   +0.01%     
==========================================
  Files         245      245              
  Lines       22322    22322              
==========================================
+ Hits        19642    19645       +3     
+ Misses       2680     2677       -3     
Impacted Files Coverage Δ
glue/_deps.py 66.38% <ø> (ø)
glue/plugins/dendro_viewer/layer_style_editor.py 0.00% <0.00%> (ø)
glue/utils/qt/helpers.py 53.93% <ø> (ø)
glue/viewers/image/qt/slice_widget.py 72.34% <0.00%> (ø)
glue/app/qt/save_data.py 92.23% <100.00%> (ø)
glue/core/callback_property.py 100.00% <100.00%> (ø)
glue/core/data_combo_helper.py 91.53% <100.00%> (ø)
glue/core/layer_artist.py 80.00% <100.00%> (ø)
glue/core/state_objects.py 90.87% <100.00%> (ø)
glue/core/visual.py 84.44% <100.00%> (ø)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8294ea...bbaf33e. Read the comment docs.

@astrofrog astrofrog merged commit 656ddb7 into glue-viz:master Apr 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant