Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve efficiency of image viewer when using dask arrays #2137

Merged
merged 9 commits into from
May 18, 2020

Conversation

astrofrog
Copy link
Member

This is an alternative to #2136 and I find it cleaner since it is consistent with the conceptual behavior for non-dask arrays, and doesn't change anything for non-dask arrays.

More work is needed to make glue fully benefit from dask arrays, but this is a start.

@codecov
Copy link

codecov bot commented May 12, 2020

Codecov Report

Merging #2137 into master will decrease coverage by 0.10%.
The diff coverage is 51.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2137      +/-   ##
==========================================
- Coverage   87.99%   87.88%   -0.11%     
==========================================
  Files         245      245              
  Lines       22322    22409      +87     
==========================================
+ Hits        19642    19695      +53     
- Misses       2680     2714      +34     
Impacted Files Coverage Δ
glue/utils/array.py 89.49% <10.52%> (-5.86%) ⬇️
glue/core/fixed_resolution_buffer.py 88.52% <50.00%> (-6.12%) ⬇️
glue/core/data.py 91.37% <57.14%> (+0.26%) ⬆️
glue/core/component.py 91.28% <59.45%> (-5.78%) ⬇️
glue/core/data_factories/helpers.py 93.01% <100.00%> (+0.07%) ⬆️
glue/core/link_manager.py 97.64% <100.00%> (ø)
glue/plugins/coordinate_helpers/link_helpers.py 100.00% <100.00%> (ø)
glue/core/state.py 92.09% <0.00%> (+0.03%) ⬆️
glue/viewers/image/state.py 91.07% <0.00%> (+0.05%) ⬆️
glue/config.py 85.32% <0.00%> (+0.44%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 656ddb7...c2b4acf. Read the comment docs.

@astrofrog astrofrog merged commit 70d9d19 into glue-viz:master May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant