Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix histogram viewer with dask arrays #2149

Merged
merged 1 commit into from
May 25, 2020

Conversation

astrofrog
Copy link
Member

Fixes #2148

@keflavich - can you confirm this works for you?

@astrofrog astrofrog added the bug label May 25, 2020
@keflavich
Copy link
Contributor

Yep, that fixed it.

@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #2149 into master will decrease coverage by 0.02%.
The diff coverage is 31.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2149      +/-   ##
==========================================
- Coverage   87.87%   87.85%   -0.03%     
==========================================
  Files         246      246              
  Lines       22596    22609      +13     
==========================================
+ Hits        19857    19863       +6     
- Misses       2739     2746       +7     
Impacted Files Coverage Δ
glue/core/data.py 90.22% <31.25%> (-1.16%) ⬇️
glue/viewers/matplotlib/qt/widget.py 81.81% <0.00%> (+3.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a746d6f...869d9c8. Read the comment docs.

@astrofrog astrofrog merged commit 0d038bf into glue-viz:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't visualize subset in histogram
2 participants