Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch get cmap method code #2168

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Patch get cmap method code #2168

merged 1 commit into from
Aug 21, 2020

Conversation

kakirastern
Copy link

Description

To patch the part of the codebase dealing with getting cmap in the case of cmap's that are native to glue but not to matplotlib. Otherwise for example in the case of IRIS Level 2 SJI data an error would be thrown to complain that there is no such cmap.

@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #2168 into master will decrease coverage by 0.01%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2168      +/-   ##
==========================================
- Coverage   87.87%   87.85%   -0.02%     
==========================================
  Files         246      246              
  Lines       22724    22730       +6     
==========================================
+ Hits        19969    19970       +1     
- Misses       2755     2760       +5     
Impacted Files Coverage Δ
glue/core/visual.py 81.13% <14.28%> (-3.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf93252...5c0249a. Read the comment docs.

Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@astrofrog astrofrog merged commit b2ca7aa into glue-viz:master Aug 21, 2020
@kakirastern
Copy link
Author

You are welcome

@kakirastern kakirastern deleted the patch-get-cmap-code branch August 21, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants