-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding polar and other plots #2170
Conversation
… Current tests pass.
…jections can't be saved to a session file just yet
…e. Also added tests for saving and loading
… Also made tweaks to tests on limits when changing modes.
…lsphere projections throw if the plot artist is set to an empty array.
…an be saved to the script properly
…different plot modes and utility
…lass and added a quick test to make sure it behaves as expected
Codecov Report
@@ Coverage Diff @@
## master #2170 +/- ##
==========================================
+ Coverage 87.86% 87.99% +0.12%
==========================================
Files 246 247 +1
Lines 22709 22944 +235
==========================================
+ Hits 19954 20189 +235
Misses 2755 2755
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work! This works very nicely for me. There are some small improvements I think we can do (including the ones you mention) but for now I think we can merge and release this.
This PR adds the ability to change the projection of the Matplotlib 2D scatter plot. To make sure that selecting ROIs on the various projections, this PR also adds the ability for ROI subset states to apply an arbitrary transform before testing for inclusion in the ROI. There are also lots of tweaks and changes to the scatter code to make sure that things like script export, color-maps, scaling, vectors, error bars, limits, log, tick formatting, etc. behave when using the different projections. A number of tests are added as well. Some future improvements that can be made to this include: