Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with recent versions of packages #2196

Merged
merged 16 commits into from
Jun 1, 2021

Conversation

astrofrog
Copy link
Member

This should help fix some of the CI failures.

@codecov
Copy link

codecov bot commented Jun 1, 2021

Codecov Report

Merging #2196 (298f162) into master (efcccbb) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2196      +/-   ##
==========================================
- Coverage   88.02%   88.00%   -0.02%     
==========================================
  Files         247      247              
  Lines       22956    22966      +10     
==========================================
+ Hits        20206    20212       +6     
- Misses       2750     2754       +4     
Impacted Files Coverage Δ
glue/_deps.py 66.38% <ø> (ø)
glue/_mpl_backend.py 88.00% <100.00%> (+2.28%) ⬆️
glue/conftest.py 59.09% <100.00%> (+1.27%) ⬆️
glue/core/component.py 96.26% <100.00%> (ø)
glue/core/data.py 91.37% <100.00%> (ø)
glue/core/data_factories/excel.py 100.00% <100.00%> (ø)
glue/viewers/scatter/layer_artist.py 97.19% <100.00%> (-0.01%) ⬇️
glue/viewers/matplotlib/qt/widget.py 73.86% <0.00%> (-3.41%) ⬇️
glue/utils/qt/helpers.py 53.93% <0.00%> (-1.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efcccbb...298f162. Read the comment docs.

@astrofrog astrofrog changed the title Fix compatibility with xlrd 2.0+ which now no longer reads xlsx Fix compatibility with recent versions of packages Jun 1, 2021
@astrofrog astrofrog merged commit d42b93a into glue-viz:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant