Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show offending bound value in error message #2220

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Aug 9, 2021

Description

I got to this exception earlier. Would have been nice to see what the bound actually was when it was triggered. Now I cannot reproduce that same error and I will lay awake at night thinking about it.

@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #2220 (47cdeba) into master (1660f74) will increase coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2220      +/-   ##
==========================================
+ Coverage   88.00%   88.06%   +0.06%     
==========================================
  Files         247      247              
  Lines       22967    22967              
==========================================
+ Hits        20213    20227      +14     
+ Misses       2754     2740      -14     
Impacted Files Coverage Δ
glue/core/fixed_resolution_buffer.py 88.52% <0.00%> (ø)
glue/core/layer_artist.py 80.57% <0.00%> (+0.57%) ⬆️
glue/app/qt/application.py 79.62% <0.00%> (+1.05%) ⬆️
glue/conftest.py 62.12% <0.00%> (+3.03%) ⬆️
glue/viewers/common/state.py 94.73% <0.00%> (+10.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1660f74...47cdeba. Read the comment docs.

@astrofrog astrofrog merged commit e5a86e7 into glue-viz:master Aug 9, 2021
@pllim pllim deleted the patch-2 branch August 9, 2021 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants