Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose delay link manager #2225

Merged
merged 6 commits into from
Aug 12, 2021

Conversation

astrofrog
Copy link
Member

This can be useful for other tools such as jdaviz

@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #2225 (da6693c) into master (3719c4f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2225      +/-   ##
==========================================
- Coverage   88.07%   88.05%   -0.02%     
==========================================
  Files         247      247              
  Lines       23039    23168     +129     
==========================================
+ Hits        20291    20401     +110     
- Misses       2748     2767      +19     
Impacted Files Coverage Δ
glue/core/data_collection.py 90.33% <100.00%> (-2.17%) ⬇️
glue/viewers/scatter/viewer.py 96.93% <0.00%> (-3.07%) ⬇️
glue/conftest.py 59.09% <0.00%> (-3.04%) ⬇️
glue/viewers/scatter/state.py 94.73% <0.00%> (-0.27%) ⬇️
glue/core/roi.py 91.68% <0.00%> (-0.24%) ⬇️
glue/viewers/scatter/layer_artist.py 97.21% <0.00%> (+0.01%) ⬆️
glue/viewers/scatter/python_export.py 97.72% <0.00%> (+0.16%) ⬆️
glue/viewers/scatter/qt/options_widget.py 93.42% <0.00%> (+0.99%) ⬆️
glue/core/util.py 73.68% <0.00%> (+1.66%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3719c4f...da6693c. Read the comment docs.

self._disable_sync_link_manager = True
yield
self._disable_sync_link_manager = False

@contextmanager
def delay_link_manager_update(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no docstring. Will this show up in API doc?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe another PR, but I think Glue could use a "performance tips and tricks" section like astropy. There are some things we could have done to speed things up but they are not intuitive.

@astrofrog
Copy link
Member Author

@pllim - yes performance tricks would be a good idea - it's hard to anticipate all the bottlenecks in advance though and as this PR shows there was no public API before to solve this particular problem

Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

glue/core/data_collection.py Outdated Show resolved Hide resolved
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p.s. Bonus would be an example code snippet showing the usage... but it does not block the merge of this PR.

astrofrog and others added 2 commits August 12, 2021 15:54
Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com>
@astrofrog astrofrog merged commit 049d3c3 into glue-viz:master Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants