Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent resetting of WCS in image if data does not change #2232

Merged
merged 3 commits into from
Sep 16, 2021

Conversation

astrofrog
Copy link
Member

This should prevent the issue of the image viewer limits resetting when markers or another image are added to the viewer

@astrofrog astrofrog added this to the v1.2.2 milestone Sep 16, 2021
@astrofrog astrofrog added the bug label Sep 16, 2021
@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #2232 (41a51a3) into main (bb0da1c) will decrease coverage by 0.00%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2232      +/-   ##
==========================================
- Coverage   88.02%   88.02%   -0.01%     
==========================================
  Files         247      247              
  Lines       23162    23164       +2     
==========================================
+ Hits        20389    20390       +1     
- Misses       2773     2774       +1     
Impacted Files Coverage Δ
glue/viewers/image/viewer.py 92.81% <80.00%> (+0.09%) ⬆️
glue/utils/qt/helpers.py 53.93% <0.00%> (-1.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb0da1c...41a51a3. Read the comment docs.

@astrofrog astrofrog merged commit 3ea1ec6 into glue-viz:main Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant