Fixes to profile viewer #2233
Merged
Fixes to profile viewer #2233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2233 +/- ##
==========================================
+ Coverage 88.02% 88.04% +0.01%
==========================================
Files 247 247
Lines 23164 23172 +8
==========================================
+ Hits 20391 20401 +10
+ Misses 2773 2771 -2
Continue to review full report at Codecov.
|
This should now be consistent with the image viewer: limits are only reset if the reference data changes, not every time a subset or dataset change or are added. This also fixes the home button to correctly reset the y limits.
astrofrog
force-pushed
the
fix-profile-reset-limits
branch
from
b157979
to
0a593c8
Compare
|
This fixes #2223 , right? |
pllim
reviewed
Sep 16, 2021
| # Make sure the limits don't change if a subset is created or another | ||
| # dataset added - they should only change if the reference data is changed | ||
| self.viewer.add_data(self.data) | ||
| self.viewer.state.x_min = 0.2 |
There was a problem hiding this comment.
I wonder if allclose check is good enough. You know floating point and all that.
There was a problem hiding this comment.
I think this is fine as it should literally return the exact same values, there is no math involved :)
pllim
reviewed
Sep 16, 2021
| # A callback event for reference_data is triggered if the choices change | ||
| # but the actual selection doesn't - so we avoid resetting the WCS in | ||
| # this case. | ||
| if before is after: |
There was a problem hiding this comment.
Is this how multiverse is created? 😆
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes three issues with the profile viewer: