Get mask in compute_histogram with call that also tries join_on_key #2242
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This is a single-line change to use a method that also tries
join_on_key
insidecompute_histogram
. Without this change, 2D scatter plots that are in density_map mode will not show selections that should propagate throughjoin_on_key
type connections.compute_statistic
indata.py
might also not working correctly withjoin_on_key
because it callssubset_state.to_mask(self, view)
-- but it also callssubset_state.to_array(self, cid)
and so this would be a larger fix (if it even is a problem).