Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get mask in compute_histogram with call that also tries join_on_key #2242

Conversation

jfoster17
Copy link
Member

Pull Request Template

Description

This is a single-line change to use a method that also tries join_on_key inside compute_histogram. Without this change, 2D scatter plots that are in density_map mode will not show selections that should propagate through join_on_key type connections. compute_statistic in data.py might also not working correctly with join_on_key because it calls subset_state.to_mask(self, view)-- but it also calls subset_state.to_array(self, cid) and so this would be a larger fix (if it even is a problem).

@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #2242 (d0a1f20) into main (112809a) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head d0a1f20 differs from pull request most recent head a1ee97b. Consider uploading reports for the commit a1ee97b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2242      +/-   ##
==========================================
- Coverage   88.04%   88.01%   -0.04%     
==========================================
  Files         247      247              
  Lines       23172    23172              
==========================================
- Hits        20402    20394       -8     
- Misses       2770     2778       +8     
Impacted Files Coverage Δ
glue/core/data.py 91.37% <100.00%> (ø)
glue/utils/qt/app.py 90.00% <0.00%> (-6.00%) ⬇️
glue/app/qt/preferences.py 88.61% <0.00%> (-2.44%) ⬇️
glue/plugins/dendro_viewer/data_factory.py 97.72% <0.00%> (-2.28%) ⬇️
glue/utils/qt/helpers.py 53.93% <0.00%> (-1.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 112809a...a1ee97b. Read the comment docs.

Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good!

@astrofrog astrofrog merged commit 8f19f94 into glue-viz:main Jan 27, 2022
@jfoster17 jfoster17 deleted the make-compute-histogram-work-with-join-on-key branch March 29, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants