Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for datasets with mixed dask and non-dask arrays, and fixes to table viewer when dask arrays are present #2249

Merged
merged 4 commits into from
Dec 16, 2021

Conversation

astrofrog
Copy link
Member

This should allow loading of MS files with casa-formats-io to work properly

@codecov
Copy link

codecov bot commented Nov 18, 2021

Codecov Report

Merging #2249 (ff69c08) into main (bb79e0f) will decrease coverage by 65.97%.
The diff coverage is 16.12%.

❗ Current head ff69c08 differs from pull request most recent head c57f906. Consider uploading reports for the commit c57f906 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2249       +/-   ##
===========================================
- Coverage   88.00%   22.03%   -65.98%     
===========================================
  Files         247      247               
  Lines       23136    22416      -720     
===========================================
- Hits        20361     4939    -15422     
- Misses       2775    17477    +14702     
Impacted Files Coverage Δ
glue/core/data.py 15.92% <0.00%> (-75.46%) ⬇️
glue/viewers/table/qt/data_viewer.py 31.85% <22.72%> (-65.83%) ⬇️
glue/app/qt/actions.py 0.00% <0.00%> (-100.00%) ⬇️
glue/io/subset_mask.py 0.00% <0.00%> (-100.00%) ⬇️
glue/app/qt/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
glue/app/qt/splash_screen.py 0.00% <0.00%> (-100.00%) ⬇️
glue/core/qt/message_widget.py 0.00% <0.00%> (-100.00%) ⬇️
glue/viewers/custom/qt/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
glue/dialogs/autolinker/qt/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
glue/dialogs/link_editor/qt/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
... and 197 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c904d1d...c57f906. Read the comment docs.

@astrofrog astrofrog merged commit bdffcca into glue-viz:main Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant