Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bundled pvextractor and updated extraction tool to work properly with changes to .coords #2252

Merged
merged 5 commits into from
Jan 27, 2022

Conversation

astrofrog
Copy link
Member

This is the start of trying to address issues seen by @keflavich with CASA spectral cubes. Still need to figure out how to properly fix pvextractor though.

@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #2252 (af93cca) into main (15c720e) will decrease coverage by 0.03%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2252      +/-   ##
==========================================
- Coverage   88.04%   88.00%   -0.04%     
==========================================
  Files         247      247              
  Lines       23175    23176       +1     
==========================================
- Hits        20405    20397       -8     
- Misses       2770     2779       +9     
Impacted Files Coverage Δ
glue/core/util.py 73.55% <66.66%> (-0.13%) ⬇️
glue/plugins/tools/pv_slicer/qt/pv_slicer.py 73.33% <80.00%> (-0.32%) ⬇️
glue/utils/array.py 88.06% <100.00%> (ø)
glue/viewers/histogram/python_export.py 91.11% <100.00%> (ø)
glue/viewers/profile/qt/profile_tools.py 90.12% <100.00%> (ø)
glue/viewers/profile/state.py 98.95% <100.00%> (ø)
glue/viewers/scatter/layer_artist.py 97.21% <100.00%> (ø)
glue/utils/qt/app.py 90.00% <0.00%> (-6.00%) ⬇️
glue/app/qt/preferences.py 88.61% <0.00%> (-2.44%) ⬇️
glue/plugins/dendro_viewer/data_factory.py 97.72% <0.00%> (-2.28%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15c720e...af93cca. Read the comment docs.

@astrofrog astrofrog marked this pull request as ready for review January 27, 2022 17:43
@astrofrog astrofrog merged commit 44469f3 into glue-viz:main Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant