Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix polar scatter serialization issue #2259

Merged
merged 2 commits into from
Jan 26, 2022

Conversation

Carifio24
Copy link
Member

This PR fixes an issue with saving glue sessions that have polar plots in degree mode. This is accomplished by creating the RadianTransform class in roi_pretransforms.py, which is glue-serializable. This replaces the previous transform that was applying the conversion to degrees (an instance of functools.partial), which glue does not know how to serialize.

@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #2259 (a89a3dd) into main (bdffcca) will decrease coverage by 0.05%.
The diff coverage is 44.44%.

❗ Current head a89a3dd differs from pull request most recent head 6eba0b5. Consider uploading reports for the commit 6eba0b5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2259      +/-   ##
==========================================
- Coverage   88.05%   88.00%   -0.06%     
==========================================
  Files         247      247              
  Lines       23156    23165       +9     
==========================================
- Hits        20391    20386       -5     
- Misses       2765     2779      +14     
Impacted Files Coverage Δ
glue/core/roi_pretransforms.py 76.92% <40.00%> (-23.08%) ⬇️
glue/viewers/scatter/viewer.py 98.91% <50.00%> (+1.97%) ⬆️
glue/core/state.py 92.12% <100.00%> (ø)
glue/_mpl_backend.py 80.00% <0.00%> (-8.00%) ⬇️
glue/dialogs/data_wizard/qt/data_wizard_dialog.py 91.46% <0.00%> (-2.44%) ⬇️
glue/utils/qt/app.py 94.00% <0.00%> (-2.00%) ⬇️
glue/conftest.py 53.03% <0.00%> (-1.52%) ⬇️
glue/utils/qt/helpers.py 53.93% <0.00%> (-1.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdffcca...6eba0b5. Read the comment docs.

Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Could you add a changelog entry?

@Carifio24
Copy link
Member Author

Added the changelog entry

@astrofrog astrofrog merged commit efe0aac into glue-viz:main Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants