Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile viewer: reset y limits when changing collapse function #2277

Merged
merged 2 commits into from
Apr 7, 2022

Conversation

kecnry
Copy link
Contributor

@kecnry kecnry commented Feb 22, 2022

Description

This PR resets the y-limits of a profile viewer when the collapse function is changed (similar to what is currently done for normalize - the plotted data have changed in y, so the existing y-limits are meaningless).

@codecov
Copy link

codecov bot commented Feb 22, 2022

Codecov Report

Merging #2277 (52566b1) into main (1843787) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2277   +/-   ##
=======================================
  Coverage   88.13%   88.13%           
=======================================
  Files         247      247           
  Lines       23292    23305   +13     
=======================================
+ Hits        20528    20541   +13     
  Misses       2764     2764           
Impacted Files Coverage Δ
glue/viewers/profile/state.py 99.01% <100.00%> (+0.06%) ⬆️
glue/viewers/table/qt/data_viewer.py 97.42% <0.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1843787...52566b1. Read the comment docs.

@astrofrog
Copy link
Member

@kecnry - we've fixed some of the CI issues recently so could you rebase to see if the failures here are real?

@kecnry kecnry force-pushed the profile-reset-y-on-function-changed branch from 9bafeb3 to 2d640b5 Compare March 17, 2022 12:50
@kecnry
Copy link
Contributor Author

kecnry commented Mar 17, 2022

@astrofrog - rebased but many are still failing. Is it possible the tests would need updating to account for this scenario? Or is there a reason I'm missing where this is not the desired behavior?

@astrofrog
Copy link
Member

I'll investigate, thanks!

@astrofrog
Copy link
Member

This turned out to reveal a subtle issue which was that state classes when used not in the context of a GUI were not subscribing to subset updates, so I've now fixed this properly. Let's see if this makes the CI happy now!

@astrofrog astrofrog changed the title profile viewer: reset y limits when changing collapse function Profile viewer: reset y limits when changing collapse function Apr 7, 2022
@astrofrog astrofrog merged commit c038ccb into glue-viz:main Apr 7, 2022
@kecnry kecnry deleted the profile-reset-y-on-function-changed branch April 7, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants