Angle units in full-sphere projections #2279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2279 +/- ##
==========================================
- Coverage 88.15% 88.09% -0.07%
==========================================
Files 247 247
Lines 23327 23350 +23
==========================================
+ Hits 20565 20571 +6
- Misses 2762 2779 +17
Continue to review full report at Codecov.
|
astrofrog
force-pushed
the
proj-angle-units
branch
from
d9ecb36 to
e2222a5
Compare
|
@Carifio24 could you add a changelog entry for a new 1.4.0 version in the changelog? |
|
@astrofrog Just added the changelog entry |
…rojections. Fix an issue with the radian formatter that never surfaced in polar mode.
…n apply to either coordinate in the full-sphere projections.
…transform on based on the projection type.
astrofrog
force-pushed
the
proj-angle-units
branch
from
4817497 to
5c64fe2
Compare
|
I've rebased to fix a conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for using degrees in the four full-sphere projections (Aitoff, Hammer, Mollweide, and Lambert) in the scatter viewer. Tick mark formatting has also been adjusted to match the angle units being used (tick mark locations have been left unchanged). I split the full-sphere projection test (in the Qt scatter viewer tests) into two separate tests, one for each angle unit.
Since the
RadianTransformROI pre-transform originally only applied the transformation to the x component (as it was created with polar plots in mind), I added acoordsparameter which allows specifying which coordinates are angular, as the full-sphere projections have two angular coordinates. This would cause a problem for older sessions that use a previous version ofRadianTransform. To work around this, I've added a patch which will set coords to be['x']if it's missing (since this would be the appropriate value for polar plots).