Don't call logging.basicConfig as this can modify logging globally #2281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @orifox and @jemorrison |
Codecov Report
@@ Coverage Diff @@
## main #2281 +/- ##
==========================================
+ Coverage 88.09% 88.13% +0.03%
==========================================
Files 247 247
Lines 23293 23292 -1
==========================================
+ Hits 20521 20528 +7
+ Misses 2772 2764 -8
Continue to review full report at Codecov.
|
astrofrog
changed the title
|
I am going to merge this as it does solve most of the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully solve #2278 (it seems to locally for me)