-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying visual attributes when creating subset group #2297
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2297 +/- ##
=======================================
Coverage 88.15% 88.15%
=======================================
Files 247 247
Lines 23325 23327 +2
=======================================
+ Hits 20563 20565 +2
Misses 2762 2762
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Could you add a test though?
32c8909
to
5471066
Compare
@astrofrog I've added two tests - one to check that the correct default values are applied in I've also changed the default value for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
This PR allows specifying visual attributes when creating a new subset group, either via the
SubsetGroup
initializer or theDataCollection::new_subset_group
method.I don't know that this adds much, if any, utility to the standard glue workflow - the intended use case here is for dashboard-style applications like Cosmic Data Stories. In a setting where the application is doing the styling, the delay between creating the new subset group and modifying the styling is occasionally visible, which this PR is looking to solve.