Fix issue where matplotlib viewers using y log axes were not initialized correctly.
#2324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Carifio24 - could you rebase to resolve the conflict in |
Carifio24
force-pushed
the
update-ylog-start
branch
from
1ecc1ca
to
3957db5
Compare
|
@astrofrog Should be good now! |
dhomeier
changed the title
y log axes were not initialized correctly.
dhomeier
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #2194, which actually affects any of the matplotlib viewers that use log axes. The reason for the incorrect aspect described in the issue is that we currently only update the x log axes when setting up callbacks. This PR adds a call to
update_y_logas well.