Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement linking support for all BaseCartesianData subclasses and fix bugs that caused hanging in image viewer #2328

Merged
merged 7 commits into from
Oct 11, 2022

Conversation

astrofrog
Copy link
Member

@astrofrog astrofrog commented Oct 10, 2022

This is an attempt to implement linking for all BaseCartesianData subclasses and making sure the fixed resolution buffer calculation works for these.

TODO:

  • Any required updates to documentation
  • Document in code the internal use of component objects even though those aren't in the public API
  • Investigate slowdown (happens even with older Matplotlib versions)
  • Make sure that we re-instate support for pixel<->world linking for datasets that use this
  • Check that things work properly in a real-life test

@astrofrog
Copy link
Member Author

Seems to work ok but noticing some slowness in the UI which usually indicates an infinite loop of some kind, so will investigate

@astrofrog
Copy link
Member Author

Here is the example script I am using for now: https://gist.github.com/astrofrog/5961aaa7f4fb3fa05c6f411b7b819a0f

@astrofrog astrofrog marked this pull request as ready for review October 11, 2022 10:34
@astrofrog
Copy link
Member Author

This incidentally solves two long-standing bugs which caused (under certain conditions) infinite loops in redrawing in the image viewer, hence why it is labelled as Bug in addition to Enhancement.

@astrofrog astrofrog changed the title Implement linking support for all BaseCartesianData subclasses Implement linking support for all BaseCartesianData subclasses and fix bugs that caused hanging in image viewer Oct 11, 2022
@astrofrog astrofrog merged commit c0219dc into glue-viz:main Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant