Require Python>=3.8 and PyQt5/PySide5>=5.14 #2334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrofrog
force-pushed
the
bump-requirements
branch
from
b622e11
to
2958ce4
Compare
astrofrog
force-pushed
the
bump-requirements
branch
from
aabcc46
to
3a1a7eb
Compare
dhomeier
reviewed
Oct 14, 2022
| @@ -1,6 +1,6 @@ | |||
| [tox] | |||
| envlist = | |||
| py{37,38,39,310}-{codestyle,test,docs}-{pyqt59,pyqt510,pyqt511,pyqt512,pyqt513,pyside511,pyside512,pyside513,pyside514,pyside515,pyqt63,pyside63}-all-{dev,legacy} | |||
| py{38,39,310}-{codestyle,test,docs}-{pyqt514,pyqt515,pyside514,pyside515,pyqt63,pyside63}-all-{dev,legacy} | |||
There was a problem hiding this comment.
Where is envlist used anyway? pyqt64 is missing here, but that does not seem to break anything.
Is it for running a blanket tox "run everything" without any arguments?
There was a problem hiding this comment.
Yes it's just for the 'run everything' which I never use anyway. But I can add the missing one.
There was a problem hiding this comment.
Actually since not critical I will add it in my PyQt6 PR
dhomeier
approved these changes
Oct 14, 2022
dhomeier
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it's becoming increasingly hard to test against all version combinations, I think it's reasonable to now bump the minimum required Python and PyQt/PySide (and looks like PyQt5 5.15 is now the latest version on conda as of a few months ago).
I have tried to simplify the build matrix a bit - and for now I've disabled the allowed failures and will add things back there if they do indeed fail.