Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyQt6 and PySide6 status to glue-deps information #2338

Merged
merged 2 commits into from
Oct 28, 2022

Conversation

dhomeier
Copy link
Collaborator

Description

With support for both backends now functional adding them to gui_framework.
Also updating string formatting (probably don't really need most of the {:s} formats) and adding info to make glue-deps info Python work.

Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but there are three tests that need updating

@dhomeier
Copy link
Collaborator Author

dhomeier commented Oct 25, 2022

I think the tests were correct. Ah, the subtle details of f-string alignment!

@astrofrog astrofrog merged commit 66550d2 into glue-viz:main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants