Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Fix equivalent_units in examples #2369

Merged
merged 1 commit into from
Mar 1, 2023
Merged

DOC: Fix equivalent_units in examples #2369

merged 1 commit into from
Mar 1, 2023

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Feb 28, 2023

I think the example is wrong?

glue/glue/core/units.py

Lines 52 to 53 in 11a5dde

def equivalent_units(self, data, cid, units):
return map(str, u.Unit(units).find_equivalent_units(include_prefix_units=True))

dhomeier
dhomeier approved these changes Feb 28, 2023
View reviewed changes
Copy link
Collaborator

@dhomeier dhomeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct, thanks!

astrofrog
astrofrog approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@astrofrog astrofrog merged commit d7f83b0 into glue-viz:main Mar 1, 2023
@pllim pllim deleted the patch-2 branch March 1, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhomeier dhomeier dhomeier approved these changes

@astrofrog astrofrog astrofrog approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pllim @astrofrog @dhomeier