Avoid interference of ROI patches with legend auto-placement #2370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhomeier
force-pushed
the
i-shrunk-the-patch
branch
from
1bccde3
to
de60339
Compare
|
@Carifio24, @astrofrog I have tried to implement the suggested approach from #2368 (comment) in |
Carifio24
requested changes
Mar 6, 2023
dhomeier
force-pushed
the
i-shrunk-the-patch
branch
3 times, most recently
from
372e4a7
to
759dee9
Compare
Co-authored by: Jon Carifio <carifio24@gmail.com>
dhomeier
force-pushed
the
i-shrunk-the-patch
branch
from
759dee9
to
522d926
Compare
dhomeier
changed the title
Carifio24
approved these changes
Mar 21, 2023
|
Thanks for your assistance @Carifio24! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reported in #2368; as of matplotlib 3.7 legend auto-placement is affected by the position of ROIs, even if empty. Notably 4 tests in viewers/scatter failed as the default placement of a
MplPolygonalROIpushed the legends out of their usual position.As a workaround the default extent and position of the ROI is moved from
[0, 1], [0, 1]to[0.2, 0.3], [0.2, 0.3]to keep out of the way of any of the 9 standard positions for the legend. Better fix would be to hold off syncing the patch until the ROI is made visible. Alternatively xfail for matplotlib >= 3.7.