Fixed a bug in the plugin iteration on Python 3.8 and 3.9 #2377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neutrinoceros
changed the title
neutrinoceros
force-pushed
the
hotfix_importlib_metadata
branch
from
d3dfb8f
to
c451e26
Compare
dhomeier
approved these changes
Mar 21, 2023
There was a problem hiding this comment.
Ah, I did not get the difference between importlib.metadata and importlib_metadata.
Actually 'importlib-metadata>=3.6; python_version < "3.10"' had already been installed, apparently pulled in via something else, but better to make this explicit.
Thanks for the quick fix!
dhomeier
changed the title
|
Just for the sake of being as clear as possible, here's the dependency chain that was causing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix a regression introduced and discussed in #2365
ping @dhomeier