Add a LinkSameWithUnits class that links respecting units #2379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrofrog
force-pushed
the
add-link-with-units
branch
from
fcbd52f
to
5069f36
Compare
24 tasks
|
Will the recommendations in https://jdaviz.readthedocs.io/en/latest/dev/links.html be changed by this PR? |
pllim
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Yes, a simple test over at spacetelescope/jdaviz#2048 shows this works. Thanks!
pllim
added a commit
to pllim/jdaviz
that referenced
this pull request
Mar 28, 2023
and add change log. [ci skip] [rtd skip]
pllim
added a commit
to pllim/jdaviz
that referenced
this pull request
Mar 29, 2023
and add change log. [ci skip] [rtd skip]
astrofrog
force-pushed
the
add-link-with-units
branch
from
5069f36
to
c1aca0c
Compare
This was referenced Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class can be used to avoid issues such as described in https://github.com/glue-viz/glue/pull/2296/files#r1123283337 - will add tests etc shortly.