Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save legend state #2380

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Save legend state #2380

merged 2 commits into from
Apr 3, 2023

Conversation

Carifio24
Copy link
Member

@Carifio24 Carifio24 commented Mar 27, 2023

While we were dealing with the issues with legends and matplotlib 3.7, I noticed that we don't save the legend state of the matplotlib viewers. This PR adds functionality to do that, which gives a small but nice UX improvement. This shouldn't have any effect on loading existing sessions, since then the relevant record won't have a "legend" key and the new code in __setgluestate__ won't run.

Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@astrofrog astrofrog merged commit 08497fd into glue-viz:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants