Only force reference data change if message indicates that numerical values of data have changed #2385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 11, 2023
…values of data changed
astrofrog
force-pushed
the
fix-reference-data-update
branch
from
1da94a9
to
5228194
Compare
|
@kecnry , should probably test this against the unit conversion branch over at Jdaviz since I don't know if changing viewer unit should trigger this or not. Sounds like we can ignore glue-viz/glue-jupyter#350 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original intent of the
_reference_data_changed(force=True)call was for cases where the coordinate system is changed, but we don't need to always force an update in other situations that might cause_update_datato be called.