Add subtool for changing window title #2407
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains an implementation of a feature request that has been mentioned a few times in the glue meetings, which is the ability to change viewer titles. This is done via a subtool (under the same tool menu as the tool for moving viewer), which opens a dialog that allows users to change the title of the viewer. This also adds a new icon for the tab-moving icon to help distinguish, since there are now multiple subtools in that menu.
At the viewer level, I implemented this by adding a
title
callback property to the baseViewerState
class. This allows viewer titles to be persisted via a session file as well. Since the title in the state is just a string, we should be able to use this in a non-Qt context as well.