Fix Qt6 bug that prevented layers from being re-enabled #2410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfoster17
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In Qt6, check boxes emit integers instead of the proper enum (https://bugreports.qt.io/browse/QTBUG-104688). Current logic for enabling/disabling layer artists checks the value emitted against the Qt.CheckState enum, which means that the user cannot make a layer artist they have turned not-visible visible again.
This PR fixes this behavior in the layer artist view by checking for the type of the value emitted by the checkbox and adds a test for it. I have not exhaustively checked that this problem does not occur with other checkboxes elsewhere in the GUI with Qt 6.