Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filter logic so that table viewer can hide main data layer #2411

Merged
merged 3 commits into from
Jun 1, 2023

Conversation

jfoster17
Copy link
Member

Description

PR #2392 introduced a bug wherein making the underlying table dataset not visible did not remove it from the table model and display. This PR adds tests for this behavior and fixes the problem.

Copy link
Member

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@astrofrog astrofrog merged commit 802eeba into glue-viz:main Jun 1, 2023
@jfoster17 jfoster17 deleted the fix-data-visible-with-filter branch June 9, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants