Set better starting xlim and ylim for custom viewers #2422
Conversation
| self.state.x_max = self.axes.dataLim.xmax | ||
| self.state.y_min = self.axes.dataLim.ymin | ||
| self.state.y_max = self.axes.dataLim.ymax | ||
| self.limits_to_mpl() |
There was a problem hiding this comment.
Just curious, why is this needed?
There was a problem hiding this comment.
Sorry, which line(s) are you asking about? The general idea is that without something like this the limits in the state object stay at the default values of (0,1) for custom viewers rather than getting updated when data (which is normally handled by limit helpers).
There was a problem hiding this comment.
I meant the last line - since we are updating the state from the Matplotlib viewer, why do we then need to convert the state limits back to Matplotlib? Is it in case we make any changes in the state because of aspect ratio/etc?
There was a problem hiding this comment.
In any case I'll go ahead and merge, we can always tweak later if you think this isn't needed but I don't think there's any harm in doing it.
Pull Request Template
Description
As pointed out in #2420 the documentation example for a Custom Viewer (the Shot Chart) does not work well with current versions of glue because the Shot Chart x and y limits are set to 0 - 1, which contains no data. For new users this looks like it's just not working. This fix does not require any changes to the example scripts; we add a custom
add_datafunction that uses the Matplotlib bounding box to set some sensible initial limits if we haven't already set limits (which the example later does in asetupfunction).Note that we can't use
axes.relim()for this because hexbin returns a Collection which is not supported.Closes #2420