Skip test_save_aggregate_slice for Numpy 1.25.x and unpin numpy-dev
#2429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhomeier
force-pushed
the
pin-numpy-to-serialiser
branch
from
5e5d82f to
c342e5f
Compare
dhomeier
force-pushed
the
pin-numpy-to-serialiser
branch
from
c342e5f to
f1edf1a
Compare
|
I think I would rather skip one test if possible as you suggest? |
|
Done. It's still tested in the py38 and py311-lts envs now. Any thoughts how to address the actual |
dhomeier
changed the title
test_save_aggregate_slice for Numpy 1.25.x and unpin numpy-dev
astrofrog
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
GlueSerializerfailure/hang first reported in #2353 has now made it into Numpy 1.25, so to keep jobs from just timing out (and burning CI hours), this pins all tests to 1.24.x as a temporary workaround.Alternatively one could skip
test_save_aggregate_sliceconditionally on Numpy >= 1.25, but that would leave that test to be run in only one or two tests – but perhaps better, than lagging by an entire Numpy release with everything else?Might reactivate an
ltsjob withnumpy==1.24.*...Workaround for #2428