Fix bug when changing the number of bins on a histogram with modified/deleted data #2451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used without inheritance
…error when updating the number of bins in a histogram after having removed a dataset from the DataCollection
astrofrog
force-pushed
the
fix-histogram-state-bug
branch
from
da0b5f7
to
d905492
Compare
|
The docs failure is unrelated |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue that was seen in spacetelescope/jdaviz#2529 which is that if we change the dataset used for the x attribute for the histogram, this failed if the original dataset was removed from the data collection or if the new dataset was not linked to the original one.