Customizable limits percentile and behavior on updating bins when resetting limits #2455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astrofrog
force-pushed
the
customizable-limits-percentile
branch
from
9010c4d
to
f1410a6
Compare
9 tasks
kecnry
added a commit
to astrofrog/jdaviz
that referenced
this pull request
Oct 31, 2023
…e percentile to use when determining the min/max in reset_limits, and also added a property to the histogram state to determine whether bins are updated when calling reset_limits.
dhomeier
force-pushed
the
customizable-limits-percentile
branch
from
f1410a6
to
bf5805a
Compare
dhomeier
force-pushed
the
customizable-limits-percentile
branch
from
bf5805a
to
422cbe0
Compare
dhomeier
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Code and tests look ok, taking spacetelescope/jdaviz#2529 (comment) as confirmation that this works.
kecnry
added a commit
to spacetelescope/jdaviz
that referenced
this pull request
Nov 16, 2023
* fix percentile and bins when resetting limits requires glue-viz/glue#2455 * update glue-core pin to v1.16.0 --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> Co-authored-by: Kyle Conroy <kyleconroy@gmail.com>
rosteen
pushed a commit
to rosteen/jdaviz
that referenced
this pull request
Nov 29, 2023
* fix percentile and bins when resetting limits requires glue-viz/glue#2455 * update glue-core pin to v1.16.0 --------- Co-authored-by: P. L. Lim <2090236+pllim@users.noreply.github.com> Co-authored-by: Kyle Conroy <kyleconroy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to specify the percentile to use when auto-determining limits, and makes it also possible to avoid resetting bins when calling
reset_limits().