Write docs on how to make a fully custom Qt widget for glue #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ChrisBeaumont - this is currently a WIP, and the language needs improving, but feel free to already comment on this. Should we explicitly state (as I tried to near the start) that it's best/cleanest to separate the widget functionality from the I wonder whether it would benefit the code inside glue to also follow this approach - and it would make all the existing data viewers usable outside glue (though that may not be very meaningful for some). |
astrofrog
force-pushed
the
new-viewer-docs
branch
from
0cfe273
to
a3532df
Compare
astrofrog
force-pushed
the
new-viewer-docs
branch
from
a3532df
to
4f26758
Compare
|
@ChrisBeaumont - does this look ok? If so, I'd like to merge before 0.5. It could be expanded further, but I think it would be good to already have this. |
Closed
|
Looks good! |
astrofrog
added a commit
that referenced
this pull request
Jun 22, 2015
Write docs on how to make a fully custom Qt widget for glue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will do this once #617 is finalized